target/riscv: new ebreak controls
#1168
Merged
+295
−80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
en-sc
force-pushed
the
en-sc/ebreak
branch
2 times, most recently
from
6b1faa6 to
ccb13a1
Compare
|
@JanMatCodasip, @MarekVCodasip ping |
en-sc
commented
Dec 9, 2024
|
Please, note: In the last change I didn't only address review comments. |
en-sc
commented
Dec 18, 2024
* Deprecate `riscv set_ebreak*` commands. * Introduce RISC-V-sepecific `configure` parameter `-ebreak` instead. * Separate controls for VS and VU modes. Change-Id: I0ff88318dcb52af6923eb9f20f9d0c056ad09cf0 Signed-off-by: Evgeniy Naydanov <[email protected]>
|
@JanMatCodasip, can you please double-check and re-approve the patch. I'd like to merge it. |
|
@en-sc If I read the changes since the last review correctly, this patch has only been rebased (without further changes). Is that correct? If so, it LGTM :) |
JanMatCodasip
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
riscv set_ebreak*commands.configureparameter-ebreakinstead.Change-Id: I0ff88318dcb52af6923eb9f20f9d0c056ad09cf0