using the fixed localhost as the endpoint, so that the client verify …

…the host could success during the TLS handshake
ripplehang · Oct 16, 2024 · 94623a2 · 94623a2
1 parent 62d0294
commit 94623a2
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 1 deletion.
diff --git a/cpp/src/arrow/filesystem/s3_test_util.cc b/cpp/src/arrow/filesystem/s3_test_util.cc
@@ -50,7 +50,7 @@ const char* kEnvConnectString = "ARROW_TEST_S3_CONNECT_STRING";
 const char* kEnvAccessKey = "ARROW_TEST_S3_ACCESS_KEY";
 const char* kEnvSecretKey = "ARROW_TEST_S3_SECRET_KEY";
 
-std::string GenerateConnectString() { return GetListenAddress(); }
+std::string GenerateConnectString() { return GetListenAddress("localhost"); }
 
 }  // namespace
 

diff --git a/cpp/src/arrow/testing/util.cc b/cpp/src/arrow/testing/util.cc
@@ -206,6 +206,12 @@ std::string GetListenAddress() {
   return ss.str();
 }
 
+std::string GetListenAddress(const std::string& host) {
+  std::stringstream ss;
+  ss << host << ":" << GetListenPort();
+  return ss.str();
+}
+
 const std::vector<std::shared_ptr<DataType>>& all_dictionary_index_types() {
   static std::vector<std::shared_ptr<DataType>> types = {
       int8(), uint8(), int16(), uint16(), int32(), uint32(), int64(), uint64()};

diff --git a/cpp/src/arrow/testing/util.h b/cpp/src/arrow/testing/util.h
@@ -128,6 +128,10 @@ ARROW_TESTING_EXPORT int GetListenPort();
 // port conflicts.
 ARROW_TESTING_EXPORT std::string GetListenAddress();
 
+// Get a "host:port" to listen on. Compared to GetListenAddress(), this function would use
+// the host passed in.
+ARROW_TESTING_EXPORT std::string GetListenAddress(const std::string& host);
+
 ARROW_TESTING_EXPORT
 const std::vector<std::shared_ptr<DataType>>& all_dictionary_index_types();