change quantity to int

rimantasrickus · Jun 4, 2024 · 6943537 · 6943537
1 parent 7c05a4e
commit 6943537
Show file tree

Hide file tree

Showing 20 changed files with 24 additions and 24 deletions.
diff --git a/src/Nodes/Invoice/Item.php b/src/Nodes/Invoice/Item.php
@@ -39,10 +39,10 @@ class Item implements NodeInterface
 
     /**
      * @Serializer\Expose
-     * @Serializer\Type("float")
+     * @Serializer\Type("int")
      * @Serializer\SerializedName("QUANTITY")
      *
-     * @var float
+     * @var int
      */
     protected $quantity;
 

diff --git a/src/Nodes/Order/Item.php b/src/Nodes/Order/Item.php
@@ -33,10 +33,10 @@ class Item implements NodeInterface
 
     /**
      * @Serializer\Expose
-     * @Serializer\Type("float")
+     * @Serializer\Type("int")
      * @Serializer\SerializedName("QUANTITY")
      *
-     * @var float
+     * @var int
      */
     protected $quantity;
 

diff --git a/src/Nodes/OrderResponse/Item.php b/src/Nodes/OrderResponse/Item.php
@@ -29,10 +29,10 @@ class Item implements NodeInterface
 
     /**
      * @Serializer\Expose
-     * @Serializer\Type("float")
+     * @Serializer\Type("int")
      * @Serializer\SerializedName("QUANTITY")
      *
-     * @var float
+     * @var int
      */
     protected $quantity;
 

diff --git a/tests/Nodes/OrderChangeTest.php b/tests/Nodes/OrderChangeTest.php
@@ -56,7 +56,7 @@ public function testMinimalInvoice()
                             'value' => 'product-number-1'
                         ]
                     ],
-                    'quantity' => -5,
+                    'quantity' => 5,
                     'orderUnit' => 'C62',
                 ]
             ],
@@ -68,7 +68,7 @@ public function testMinimalInvoice()
 
         $xml = $this->serializer->serialize($node, 'xml');
 
-        $this->assertEquals(file_get_contents(__DIR__.'/../assets/minimal_valid_orderchange.xml'), $xml);
+        $this->assertEquals(file_get_contents(__DIR__ . '/../assets/minimal_valid_orderchange.xml'), $xml);
 
         $this->assertTrue(SchemaValidator::isValid($xml, '2.1'));
     }

diff --git a/tests/assets/minimal_valid_invoice.xml b/tests/assets/minimal_valid_invoice.xml
@@ -21,7 +21,7 @@
     <INVOICE_ITEM>
       <LINE_ITEM_ID><![CDATA[line-item-id-1]]></LINE_ITEM_ID>
       <PRODUCT_ID/>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
       <PRODUCT_PRICE_FIX>
         <bmecat:PRICE_AMOUNT>123.0</bmecat:PRICE_AMOUNT>

diff --git a/tests/assets/minimal_valid_invoice_with_delivery_date.xml b/tests/assets/minimal_valid_invoice_with_delivery_date.xml
@@ -25,7 +25,7 @@
     <INVOICE_ITEM>
       <LINE_ITEM_ID><![CDATA[line-item-id-1]]></LINE_ITEM_ID>
       <PRODUCT_ID/>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
       <PRODUCT_PRICE_FIX>
         <bmecat:PRICE_AMOUNT>123.0</bmecat:PRICE_AMOUNT>

diff --git a/tests/assets/minimal_valid_order.xml b/tests/assets/minimal_valid_order.xml
@@ -24,7 +24,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_order_with_address.xml b/tests/assets/minimal_valid_order_with_address.xml
@@ -42,7 +42,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_order_with_contactdetails.xml b/tests/assets/minimal_valid_order_with_contactdetails.xml
@@ -40,7 +40,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_order_with_delivery_date.xml b/tests/assets/minimal_valid_order_with_delivery_date.xml
@@ -28,7 +28,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_order_with_delivery_date_in_order_item.xml b/tests/assets/minimal_valid_order_with_delivery_date_in_order_item.xml
@@ -24,7 +24,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
       <DELIVERY_DATE>
         <DELIVERY_START_DATE><![CDATA[2020-02-27]]></DELIVERY_START_DATE>

diff --git a/tests/assets/minimal_valid_order_with_payment_account.xml b/tests/assets/minimal_valid_order_with_payment_account.xml
@@ -33,7 +33,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_order_with_payment_card_amex.xml b/tests/assets/minimal_valid_order_with_payment_card_amex.xml
@@ -31,7 +31,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_order_with_payment_cash.xml b/tests/assets/minimal_valid_order_with_payment_cash.xml
@@ -27,7 +27,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_order_with_payment_check.xml b/tests/assets/minimal_valid_order_with_payment_check.xml
@@ -27,7 +27,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_order_with_payment_debit.xml b/tests/assets/minimal_valid_order_with_payment_debit.xml
@@ -27,7 +27,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_order_with_udx.xml b/tests/assets/minimal_valid_order_with_udx.xml
@@ -25,7 +25,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
       <ITEM_UDX>
         <UDX.acme.abc><![CDATA[123]]></UDX.acme.abc>

diff --git a/tests/assets/minimal_valid_order_with_udx_header.xml b/tests/assets/minimal_valid_order_with_udx_header.xml
@@ -29,7 +29,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>10.0</QUANTITY>
+      <QUANTITY>10</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDER_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_orderchange.xml b/tests/assets/minimal_valid_orderchange.xml
@@ -25,7 +25,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>-5.0</QUANTITY>
+      <QUANTITY>5</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDER_ITEM>
   </ORDERCHANGE_ITEM_LIST>

diff --git a/tests/assets/minimal_valid_orderresponse.xml b/tests/assets/minimal_valid_orderresponse.xml
@@ -25,7 +25,7 @@
       <PRODUCT_ID>
         <bmecat:SUPPLIER_PID><![CDATA[product-number-1]]></bmecat:SUPPLIER_PID>
       </PRODUCT_ID>
-      <QUANTITY>5.0</QUANTITY>
+      <QUANTITY>5</QUANTITY>
       <bmecat:ORDER_UNIT><![CDATA[C62]]></bmecat:ORDER_UNIT>
     </ORDERRESPONSE_ITEM>
   </ORDERRESPONSE_ITEM_LIST>