Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Movie recommender class implemented #76

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

lromero21
Copy link

@lromero21 lromero21 commented Oct 8, 2019

The movie recommender, all test successful

Copy link
Owner

@rilopez rilopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please clean up your PR, this is not ready to be reviewed

@@ -0,0 +1,19 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .idea files should be ignored

pom.xml Outdated
@@ -26,5 +26,6 @@
<version>4.7</version>
<scope>test</scope>
</dependency>

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you making this empty line change?

contador++;
}
}catch (IndexOutOfBoundsException ioub){
// System.out.println("LLEGO VACIO EXCEPTION");
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to remove this comment and handle the exception



int getTotalReviews(String archivo) throws FileNotFoundException, IOException {
String cadena;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please do not mix spanish and english

char slash;
char u;
int contador = 0;
//char e;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a comment is not a way to temporally remove code, please use git instead

@lromero21 lromero21 changed the title Movies recommender working Movie recommender class implemented Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants