Implements MovieRecommender class #72
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
October 4, 2019 17:13
iuresti
suggested changes
Oct 10, 2019
| <dependency> | ||
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>21.0</version> |
| * Generates a .csv file with the relevant information in the correct format. | ||
| * Loads the users, products and reviews info. | ||
| */ | ||
| public void readFile() { |
There was a problem hiding this comment.
You're mixing responsibilities in this class, I recommend to split into 3 classes:
- One to represent your data that only has setters and getters
- One that take cares of the translation of the input file to the csv file. This class does not need to have a state, the input file and the output file can be provided in the method processing the input.
- One that uses the first one and provides the method
getRecommendationsForUser
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test completed sucessfully.