Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update main.yml to include the proper name #346

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

riemers
Copy link
Owner

@riemers riemers commented Aug 20, 2024

It now auto releases an ansible-gitlab-runner which is not the main/name of the role. This should fix that and auto import it whenever a new release is created.

@riemers
Copy link
Owner Author

riemers commented Aug 20, 2024

@guenhter , i think the only good way is to rename it to gitlab_runner or perhaps gitlabrunner, what do you think? Otherwise i'll just ask someone from galaxy (assuming it doesn't take ages) to rename it to that. Then we can adjust the role_name and updates will always point to the correct one. I now have to do a release and then have to go to galaxy to manually import the dashed version. Eventually we get stuck i would say.

@guenhter
Copy link
Collaborator

I don't dare to make any guesses here :) , ansible galaxy is not where I have a lot of experience with...

@riemers
Copy link
Owner Author

riemers commented Aug 20, 2024

i'll see what i can do about that, best is to go with the standard at some point as i have to do "manual" stuff brrr..

@@ -1,5 +1,5 @@
---
profile: production
warn_list:
- role-name # until role name is fixed on galaxy https://github.com/riemers/ansible-gitlab-runner/pull/312
# - role-name # until role name is fixed on galaxy https://github.com/riemers/ansible-gitlab-runner/pull/312
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i guess you can remove this line completely

Copy link

github-actions bot commented Oct 8, 2024

Although PRs are appreciated, if it sits for too long nothing happens. Can always update and do again :) This is just the automation talking

@github-actions github-actions bot added the Stale label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants