Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update node to v20 and npm to v9 or newer #1819

Merged
merged 16 commits into from
Oct 26, 2023
Merged

chore: update node to v20 and npm to v9 or newer #1819

merged 16 commits into from
Oct 26, 2023

Conversation

mrgoltstein
Copy link
Contributor

@mrgoltstein mrgoltstein commented Oct 25, 2023 •
edited
Loading

This PR upgrades node & npm versions to latest LTS so that dependabot can resume normal operations.

This Pull Request fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added if needed.
  • Does not affect documentation or it has been added or updated.

@github-actions
Copy link

github-actions bot commented Oct 25, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6652675858

  • 2 of 2 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6013567656: 0.0%
Covered Lines: 241
Relevant Lines: 241
💛 - Coveralls

@mrgoltstein mrgoltstein changed the title chore: update node and npm versions chore: update to node 20 and npm 9 or higher Oct 25, 2023
@mrgoltstein mrgoltstein changed the title chore: update to node 20 and npm 9 or higher chore: update node to v20 and npm to v9 or newer Oct 25, 2023
@mrgoltstein mrgoltstein marked this pull request as ready for review October 25, 2023 15:34
@mrgoltstein mrgoltstein requested review from a team and aaneitchik and removed request for aaneitchik October 25, 2023 15:34
dicearr
dicearr reviewed Oct 26, 2023
View reviewed changes
package.json Show resolved Hide resolved
griseau
griseau approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

@griseau griseau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@griseau griseau merged commit e7a4052 into master Oct 26, 2023
6 checks passed
@griseau griseau deleted the mrgolt/bump-node branch October 26, 2023 10:23
griseau pushed a commit that referenced this pull request Oct 26, 2023
@mrgoltstein @griseau
chore!: update node to v20 and npm to v9 or newer (#1819)
5f4dfba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dicearr dicearr dicearr left review comments

@griseau griseau griseau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrgoltstein @dicearr @griseau