Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating and path fixed #2

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

spekulatius
Copy link

Hello @rickwest,

sorry for the wrong PR. It was still WIP.

It's ready now: I've updated the dependencies and fixed a path in the SCSS to get it working again.

Maybe something you want to merge? If not that's fine too :)

Cheers,
Peter

@spekulatius
Copy link
Author

hmm, that's rather different than what I get on my fork on Netlify. This configuration works for with a new site. I guess the Netlify configuration doesn't update with the netlify.toml file, does it?

@rickwest
Copy link
Owner

Hey thanks for the PR, it's been a while since I updated my own site (based on this template), so I hadn't even realised it had any issues. Really appreciate you taking the time to fix this!

hmm, that's rather different than what I get on my fork on Netlify. This configuration works for with a new site. I guess the Netlify configuration doesn't update with the netlify.toml file, does it?

Yeah, I suspect this is caused by something I've got configured in the Netlify dashboard, I shall take a look today and see if I can spot anything 😄

@spekulatius
Copy link
Author

No worries!

Looks like some dependencies changed and with it the path. I didn't compare the old version in detail, it just broke with updating.

You can test it by tweaking the Deploy to Netlify URL with my repo - that's how it worked for me. Of course, further testing is appreciated. Thank you!

Cheers

@njames njames mentioned this pull request Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants