Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added comment for when you change callsign. #158

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

1tilen
Copy link

@1tilen 1tilen commented Sep 30, 2024

While programming the tracker for a friend who wanted to have some other APRS icons used rather than the ones that are used in the default config I noticed that not all icons are implemented in the software. I do not think it would be needed to implement those, but I got an idea that it might help to have comment printed on display during the callsign change.

Additional parameter has been added to the data json: callchangecomment. If this parameter exists it is shown on the display during the callsign change.

I think this might be better solutions as this comment can be used also for some other differences rather than only callsign icon. For example someone might like to have same callsign with same icon but different smart Beaconing settings.

@richonguzman
Copy link
Owner

sorry but I dont get the proposal intentions

another comment?

@1tilen
Copy link
Author

1tilen commented Sep 30, 2024

The current comment parameter you have in config is beacon comment and it's actually transmitted with LoRa.

Added callsign comment is shown on the display when you change callsign.

Another example:

I would like to use same callsign with same Icon but with different smart beaconing settings.
(Simplified) Data JSON would look like this:

beacons:
{
Callsign: NOCALL-7,
symbol: car,
Smartbeacon: on,
callchangecomment: "SB ON"
}
{
Callsign: NOCALL-7,
symbol: car,
Smartbeacon: off,
callchangecomment: "SB OFF"
}

And when you change callsign this callchangecomment can be seen on the display for those two seconds during callsign change.

Screen looks like this:

    INFO
CHANGING CALLSIGN
 
 --> NOCALL-7 ( SB ON)

or

    INFO
CHANGING CALLSIGN

--> NOCALL-7 ( SB OFF)

Or for example if you use Tractor Icon and instead of seeing tractor image during normal operation you see letter F.
If you use callsign comment you can write down that the selected callsign is transmitting Tractor Icon.

As I said, this callsigncomment is seen only on the display for those two seconds during callsign change.

@richonguzman
Copy link
Owner

ahhh like the "personal note" idea added a while ago into igate firmware?

@1tilen
Copy link
Author

1tilen commented Sep 30, 2024

Yes, exactly like that. :) I didn't think about naming it like that. :) I will change it the pull request right away.

@richonguzman
Copy link
Owner

the goal is to see this only when changing callings and dont send /see this info on another place, right?

@1tilen
Copy link
Author

1tilen commented Sep 30, 2024

Yes!

@richonguzman
Copy link
Owner

richonguzman commented Sep 30, 2024

great then , I will add this as soon as I finish fighting with webflasher... finally im close to have an alpha of it

I HATE JS! hahahah

@1tilen
Copy link
Author

1tilen commented Sep 30, 2024

Great to hear that. 😄

Yeah, JS is something better. 😄

Good luck with that!

@1tilen
Copy link
Author

1tilen commented Sep 30, 2024

I have changed name of this once again. After discussing it S57PNX he suggested naming it profilelabel which I aggree is more suitable for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants