Update ValueToArgumentName to support double and float

ricaun-io · Dec 9, 2024 · 03e06cd · 03e06cd
1 parent 72506df
commit 03e06cd
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 30 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 - Add `AppDomainDisposable` internal class to create a new `AppDomain` and dispose it.
 - Add `TryChangeType` to try to convert `object` to `ParameterType`.
 - Update `GetTestNameWithArguments` to support generic types.
+- Update `ValueToArgumentName` to support `double` and `float`.
 ### Tests
 - Add `SampleMetadata` and `SampleMetadataAttribute` test project.
 - Add `TestParameterCaseDouble` to test parameter with `double` type and parameter `int`. (Fix: #29)

diff --git a/Directory.Build.props b/Directory.Build.props
@@ -1,5 +1,5 @@
 <Project>
 	<PropertyGroup>
-		<Version>1.4.1-beta</Version>
+		<Version>1.4.1-beta.1</Version>
 	</PropertyGroup>
 </Project>
diff --git a/ricaun.NUnit/Services/TestAttributeService.cs b/ricaun.NUnit/Services/TestAttributeService.cs
@@ -179,42 +179,50 @@ public string GetTestName(MethodInfo method, NUnitAttribute attribute)
             return method.Name;
         }
 
-        private string GetTestNameWithArguments(MethodInfo method, params object[] objects)
+        static string GetTestNameWithArguments(MethodInfo method, params object[] objects)
         {
-            string ToArgumentName(object value)
+            return $"{method.Name}({string.Join(",", objects.Select(ValueToArgumentName))})";
+        }
+        static string ValueToArgumentName(object value)
+        {
+            if (value is null)
             {
-                if (value is null)
-                {
-                    return "null";
-                }
-                else if (value is string)
-                {
-                    return $"\"{value}\"";
-                }
-                else if (value is Type type)
+                return "null";
+            }
+            else if (value is string)
+            {
+                return $"\"{value}\"";
+            }
+            else if (value is double)
+            {
+                return $"{value}d";
+            }
+            else if (value is float)
+            {
+                return $"{value}f";
+            }
+            else if (value is Type type)
+            {
+                try
                 {
-                    try
+                    if (type.IsGenericType)
                     {
-                        if (type.IsGenericType)
-                        {
-                            var genericTypeName = type.Name.Split('`')[0];
-                            var genericArgs = type
-                                .GetGenericArguments()
-                                .Select(ToArgumentName);
-                            return $"{genericTypeName}<{string.Join(",", genericArgs)}>";
-                        }
+                        var genericTypeName = type.Name.Split('`')[0];
+                        var genericArgs = type
+                            .GetGenericArguments()
+                            .Select(ValueToArgumentName);
+                        return $"{genericTypeName}<{string.Join(",", genericArgs)}>";
                     }
-                    catch { }
-                    return type.Name;
                 }
-                else if (value is ParameterInfo parameter)
-                {
-                    var parameterType = parameter.ParameterType;                    
-                    return ToArgumentName(parameterType);
-                }
-                return $"{value}";
+                catch { }
+                return type.Name;
+            }
+            else if (value is ParameterInfo parameter)
+            {
+                var parameterType = parameter.ParameterType;                    
+                return ValueToArgumentName(parameterType);
             }
-            return $"{method.Name}({string.Join(",", objects.Select(ToArgumentName))})";
+            return $"{value}";
         }
 
         /// <summary>