Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include several tests and minor fixes #4

Merged
merged 24 commits into from
Jul 17, 2024
Merged

Conversation

ricardoleal20
Copy link
Owner

Summary 📝

Added

  • [Classifiers]: Add the classifiers for the project, including homepages and more stuff
  • [Maturin]: Add information for the correct Rust/Python project be implemented
  • [Tests]: Include the Engine and the solver tests
  • [Variable]: Now, you can directly include the initial value of the variable in their definition
  • [Variable]: Now, in the setter, the value set is going to be the closes bound if the expected value is outside the bound

Fixed

  • [Engine]: The engine now it updates the value using the setting method value, instead of going directly for the _value.

Type of change 🦺

  • 💥MAJOR CHANGE: Fix or feature that can alter the behavior of a component or project. Includes breaking changes.
  • MINOR CHANGE: Addition of new features or deprecation of existing ones, without breaking changes.
  • 🩹PATCH CHANGE: Refactor of an existing component, bug fix, or improvement of a new library without breaking changes.

How has this been tested? ⚗️

Includes new and improved tests

Checklist 📋

Ensure all the following points are satisfied before opening a Pull Request for review. If not, consider opening it as a draft.

  • 💻 My code follows the style guidelines of this project.
  • :octocat: I have performed a self-review of my code.
  • ⚠️ My code doesn't generate new warnings or alerts.
  • 🧪 New and existing tests pass successfully.
  • ✅ The checks pass successfully on my local machine.
  • 💯 My code is covered by tests.
  • 📓 Documentation and comments are added where needed.

@ricardoleal20 ricardoleal20 added bug Something isn't working enhancement New feature or request labels Jul 17, 2024
@ricardoleal20 ricardoleal20 self-assigned this Jul 17, 2024
@ricardoleal20 ricardoleal20 merged commit c31a45c into main Jul 17, 2024
3 checks passed
@ricardoleal20 ricardoleal20 deleted the ricardo/AddSolverTests branch July 17, 2024 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant