feat: initial soundxyz/sdk v0.13.2 integration with hardcoded values … #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to get up and running
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pmespresso
commented
Mar 29, 2023
| contractCalls.push({ | ||
| contractAddress: editionAddress, | ||
| // TODO: The new contract interface removed grantRoles, but there should be an equivalent function. | ||
| calldata: editionInterface.encodeFunctionData("grantRoles", [ |
There was a problem hiding this comment.
needs fix to make it build. I'm not sure if they require granting roles anymore in the new contracts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…to get up and running
This is just copy pasta from my working example before they changed up the interfaces between v0.13 - v0.14 but the changes shouldn't be too crazy.
There are hardcoded values in
state.tsAlso: