Fix type only imports 166

[download13]

Fixes #166

Type imports in guard files can be type-only imports, which some build tools need to know which import statements to drop for runtime.

Code change is only one line, but test changes involve all test guards using type-only imports.

Incompatible with typescript versions prior to 3.8, so this is probably a breaking change.

[download13]

Hang on this isn't ready. Got ahead of myself and just noticed the note about #162

[rhys-vdw]

@download13 planning to take another look at this at some stage? (no pressure)

[download13]

@rhys-vdw Yeah I kinda wandered off and forgot about it :P

Looking back at my branch I realize why I stopped working. I think at the time the versions of typescript and ts-morph in the deps were quite old, and I ran into some errors while trying to update them.

Now that those have been updated, and once #215 is merged, I should be able to use mixed type/value imports to finish off #166.

[rhys-vdw]

Awesome. Merged and ready!

[PierreMardon]

I really enjoy auto-guard, at the point I manually edit the imports to match the type imports requirements of my setup 😅
So... just pinging innocently 😇

[warna720]

Yep, looking forward to this being released 👍

[rhys-vdw]

I'm sure @download13 wouldn't mind if someone forks his branch and continues the work (if you're really keen)

[fthdgn]

I need this because of "verbatimModuleSyntax": true on tsconfig.

For this use case, isTypeOnly: project.compilerOptions.get().verbatimModuleSyntax === true can be used, instead of isTypeOnly: true.

However verbatimModuleSyntax exists only if ts-morph version is larger then 19.0.0. And this version breaks generated_type_guards_with_a_short_circuit_are_correctly_stripped_by_UglifyJS.test.ts.

Using verbatimModuleSyntax ensures that ts-auto-guard can be used on typescript versions older than 3.8, because these versions cannot make verbatimModuleSyntax === true

[rhys-vdw]

@fthdgn I'm more than happy to bring you on as a collaborator if you're interested in making this happen. I'm not a regular typescript programmer anymore, let alone a consumer of this project.

[fthdgn]

@rhys-vdw
I've received your invitation. I will accept it. Thank you. I will try to help the project on my free times.

[rhys-vdw]

@rhys-vdw I've received your invitation. I will accept it. Thank you. I will try to help the project on my free times.

No pressure of course, but I'll be here to review, merge and release if you would like to.