Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type-only imports #166

Open
mjarr opened this issue Jan 4, 2022 · 3 comments · May be fixed by #210
Open

Type-only imports #166

mjarr opened this issue Jan 4, 2022 · 3 comments · May be fixed by #210
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mjarr
Copy link

mjarr commented Jan 4, 2022

Currently .guard.ts files import needed types using normal imports, which results in ts(1371) and ts(1444) errors in my environment (svelte). Making the imports type-only would solve this issue.

@rhys-vdw
Copy link
Owner

rhys-vdw commented Jan 5, 2022

I hadn't heard of this feature. Would this change the minimum TypeScript version?

@rhys-vdw rhys-vdw added the enhancement New feature or request label Jan 5, 2022
@mjarr
Copy link
Author

mjarr commented Jan 5, 2022

They were introduced in TypeScript 3.8.
Seems like all that needs to be done to enable them is to add isTypeOnly: true to objects pushed to structures in outFile.addImportDeclarations.

@rhys-vdw
Copy link
Owner

rhys-vdw commented Jan 6, 2022

Okay cool, I think it's reasonably to upgrade the minimum version to 3.8. Note that this would not always be appropriate due to the way that classes are checked. See discussion in #162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants