Skip to content

Commit

Permalink
Fix bug rejecting packets with 100% humidity.
Browse files Browse the repository at this point in the history
An error in all previous versions of aprs-weather-submit prevented the
creation of packets with 100% relative humidity. This off-by-one error
has been corrected, and I am making this a whole new version.

Thank you to Jeffrey McPike, N9CQS, for the bug report submitted via
email.
  • Loading branch information
rhymeswithmogul committed Sep 23, 2024
1 parent cb0be8d commit 9880993
Show file tree
Hide file tree
Showing 8 changed files with 27 additions and 15 deletions.
8 changes: 6 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
## Not yet released
* Preliminary support for compiling and running against the Win32 API.
# Change Log for `aprs-weather-submit`

## Version 1.7.2
<time datetime="2024-09-23T09:09:09-04:00">September 23, 2024</time>
* Fixed a bug that would prevent users from creating APRS packets with 100% relative humidity. Thanks to Jeff (N9CQS) for the bug report!
* Minor packaging improvements for Debian repositories.

## Version 1.7.1
<time datetime="2023-11-30T00:54:00-05:00">November 30, 2023</time>
Expand Down
14 changes: 11 additions & 3 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,13 +1,21 @@
# aprs-weather-submit news

This file details all of the user-facing changes that are in version 1.7 of aprs-weather-submit. For more details, please consult the CHANGELOG file or this project's GitHub page.
This file details all of the user-facing changes that are in versions 1.7 of aprs-weather-submit. For more details, please consult the CHANGELOG file or this project's GitHub page.

## CUSTOM ICONS
## Custom Icons

The new `--icon` parameter lets you specify a character from the two symbol tables. If not specified, you will get the classic weather icon.

Note that APRS.fi does not support parsing weather data from packets that have custom icons. If this is important to you, do not use this new feature.

## ARMHF FIXES
## `armhf` Fixes

Version 1.7 did not compile on the armhf platforms. Version 1.7.1 is fixed.

## It's not the heat, it's the humidity!

Before version 1.7.2, one could not create an APRS packet with 100% relative humidity due to a bug in the code that only allowed values from 1% to 99%. This was corrected in version 1.7.2 thanks to a report from Jeff, N9CQS.

## Can this app be in Debian, please?

I've also been making behind-the-scenes improvements to how this app is packaged and installed. Users of Debian-based Linux distributions can enjoy nearly-effortless installation, upgrades, and removals.
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dnl
dnl You should have received a copy of the GNU Affero General Public License
dnl along with this program. If not, see <http://gnu.org/licenses/agpl-3.0.html>.

AC_INIT([aprs-weather-submit], [1.7.1], [https://github.com/rhymeswithmogul/aprs-weather-submit/])
AC_INIT([aprs-weather-submit], [1.7.2], [https://github.com/rhymeswithmogul/aprs-weather-submit/])
AM_INIT_AUTOMAKE([foreign subdir-objects -Wall -Werror])
AC_PREREQ
AC_PROG_INSTALL
Expand Down
7 changes: 4 additions & 3 deletions debian/changelog
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
aprs-weather-submit (1.7.1-2) UNRELEASED; urgency=medium
aprs-weather-submit (1.7.2-1) UNRELEASED; urgency=medium

* Fixed a compile-time error on armhf platforms.
* Fixed a bug that prevented creating APRS packets with 100% relative
humidity. (Thanks to Jeff, N9CQS, for the report.)

-- Colin Cogle <[email protected]> Thu, 30 Nov 2023 01:32:00 -0500
-- Colin Cogle <[email protected]> Mon, 23 Sep 2024 09:09:09 -0400
1 change: 0 additions & 1 deletion debian/docs
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
AUTHORS
CHANGELOG.md
CODE_OF_CONDUCT.md
LICENSE
NEWS.md
README.md
6 changes: 3 additions & 3 deletions debian/files
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
aprs-weather-submit-dbgsym_1.7-1.1_amd64.ddeb debug optional automatic=yes
aprs-weather-submit_1.7.1-1_amd64.buildinfo hamradio optional
aprs-weather-submit_1.7.1-1_amd64.deb hamradio optional
aprs-weather-submit-dbgsym_1.7-2.1_amd64.ddeb debug optional automatic=yes
aprs-weather-submit_1.7.2-1_amd64.buildinfo hamradio optional
aprs-weather-submit_1.7.2-1_amd64.deb hamradio optional
2 changes: 1 addition & 1 deletion src/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -458,7 +458,7 @@ main (const int argc, const char** argv)
/* Humidity, in the range from 1 to 100% (-h | --humidity) */
case 'h':
x = atoi(optarg);
if (x < 0 || x > 99)
if (x < 0 || x > 100)
{
fprintf(stderr, "%s: option `-%c' must be between 0%% and 100%%.\n", argv[0], optopt);
return EXIT_FAILURE;
Expand Down
2 changes: 1 addition & 1 deletion src/main.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ with this program. If not, see <https://www.gnu.org/licenses/agpl-3.0.html>.
#endif

#ifndef VERSION
#define VERSION "1.7.2-git"
#define VERSION "1.7.2"
#endif

/* We don't support networking on DOS at this time.
Expand Down

0 comments on commit 9880993

Please sign in to comment.