Skip to content

Commit

Permalink
Fix compile-time bug on armhf platforms.
Browse files Browse the repository at this point in the history
Our code was expecting size_t to be a long unsigned int.  However, on
armhf, it is only an unsigned int.  Turns out C99 added the printf()
modifier %zu which always works!
  • Loading branch information
rhymeswithmogul committed Nov 30, 2023
1 parent d9a3c8f commit 79b38bb
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 12 deletions.
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Version 1.7.1
<time datetime="2023-11-30T00:54:00-05:00">November 30, 2023</time>
This patch fixes a compile-time bug on armhf platforms. The format identifer `%zu` is used to get around an error about the size of `size_t`.

## Version 1.7
<time datetime="2023-11-29T23:02:00-05:00">November 29, 2023</time>
* The icon can now be changed from the default (WX) icon using the new `--icon` option.
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,7 @@ This file details all of the user-facing changes that are in version 1.7 of aprs
The new `--icon` parameter lets you specify a character from the two symbol tables. If not specified, you will get the classic weather icon.

Note that APRS.fi does not support parsing weather data from packets that have custom icons. If this is important to you, do not use this new feature.

## ARMHF FIXES

Version 1.7 did not compile on the armhf platforms. Version 1.7.1 is fixed.
2 changes: 1 addition & 1 deletion configure.ac
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ dnl
dnl You should have received a copy of the GNU Affero General Public License
dnl along with this program. If not, see <http://gnu.org/licenses/agpl-3.0.html>.

AC_INIT([aprs-weather-submit], [1.7], [https://github.com/rhymeswithmogul/aprs-weather-submit/])
AC_INIT([aprs-weather-submit], [1.7.1], [https://github.com/rhymeswithmogul/aprs-weather-submit/])
AM_INIT_AUTOMAKE([foreign subdir-objects -Wall -Werror])
AC_PREREQ
AC_PROG_INSTALL
Expand Down
8 changes: 2 additions & 6 deletions debian/changelog
Original file line number Diff line number Diff line change
@@ -1,9 +1,5 @@
aprs-weather-submit (1.7-2) jammy; urgency=medium
aprs-weather-submit (1.7.1-1) unstable; urgency=medium

* The icon can now be changed from the default (WX) icon using the new
`--icon` option.
* Output of `snprintf()` is now better checked to make sure we haven't
overflowed our buffer.
* Fixed a compile-time error on armhf platforms.

-- Colin Cogle <[email protected]> Thu, 30 Nov 2023 00:32:00 -0500
-- Colin Cogle <[email protected]> Thu, 30 Nov 2023 01:32:00 -0500
6 changes: 3 additions & 3 deletions debian/files
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
aprs-weather-submit-dbgsym_1.7-2_amd64.ddeb debug optional automatic=yes
aprs-weather-submit_1.7-2_amd64.buildinfo hamradio optional
aprs-weather-submit_1.7-2_amd64.deb hamradio optional
aprs-weather-submit-dbgsym_1.7-1.1_amd64.ddeb debug optional automatic=yes
aprs-weather-submit_1.7.1-1_amd64.buildinfo hamradio optional
aprs-weather-submit_1.7.1-1_amd64.deb hamradio optional
2 changes: 1 addition & 1 deletion man/aprs-weather-submit.man
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
.\"
.\" (This page is best viewed with the command: groff -man)
.\"
.TH aprs\-weather\-submit 1 "2023-11-29" "Version 1.7" "aprs-weather-submit General Help"
.TH aprs\-weather\-submit 1 "2023-11-30" "Version 1.7.1" "aprs-weather-submit General Help"
.SH NAME
aprs\-weather\-submit \- manually submit weather station data to the APRS-IS network
.SH DESCRIPTION
Expand Down
2 changes: 1 addition & 1 deletion src/main.h
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ with this program. If not, see <https://www.gnu.org/licenses/agpl-3.0.html>.
#endif

#ifndef VERSION
#define VERSION "1.7"
#define VERSION "1.7.1"
#endif

/* We don't support networking on DOS at this time.
Expand Down

0 comments on commit 79b38bb

Please sign in to comment.