Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if WP_REDIS_PLUGIN_PATH is defined before defining #494

Merged
merged 4 commits into from
Oct 25, 2023

Conversation

rbackert
Copy link
Contributor

When using this as a must-use plugin, developers must define WP_REDIS_PLUGIN_PATH so the drop-in can locate files. The main plugin file also defines this constant, but without checking if it's already been defined, triggering PHP warnings.

Check if constant is defined before defining it, to avoid warnings.

@tillkruss
Copy link
Member

Thanks, can you add a CHANGELOG entry too?

@tillkruss tillkruss merged commit 3b64cb3 into rhubarbgroup:develop Oct 25, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants