feat: add support for IMDSv2 #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, IMDSv2 is not supported by simple-s3's `NewUsingIAM` method, causing it to fail on EC2 instances with IMDSv2 enabled in the EC2 metadata configuration. This patch adds a failsafe method that executes PUT request on the IMDSv2 token endpoint, and based on the response decides whether IMDSv2 support needs to be enabled. Doing so will not break or require any code-level changes to existing deployments, and allows the same binaries to run on both IMDSv2 enabled and optional instances. ref: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-metadata-v2-how-it-works.html Signed-off-by: Chinmay D. Pai <[email protected]>
rhnvrm
requested changes
Jul 1, 2024
Instead of using the errors to figure out whether IMDSv2 needs to be used, we return a boolean value for useIMDSv2 from the function itself, and propagate the error to upstream function calls in the library. IMDSv2 tokens can be used in all cases, even when IMDSv2 is set to `Optional` in the EC2 Instance configuration. As such, calls with token will not fail and we should be able to send IMDSv2 requests with token even when using IMDSv1. Signed-off-by: Chinmay D. Pai <[email protected]>
rhnvrm
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, IMDSv2 is not supported by simples3's
NewUsingIAMmethod, causing it to fail on EC2 instances with IMDSv2 enabled in the EC2 metadata configuration.This patch adds a failsafe method that executes PUT request on the IMDSv2 token endpoint, and based on the response decides whether IMDSv2 support needs to be enabled. Doing so will not break or require any code-level changes to existing deployments, and allows the same binaries to run on both IMDSv2 enabled and optional instances.
ref: https://docs.aws.amazon.com/AWSEC2/latest/UserGuide/instance-metadata-v2-how-it-works.html