Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a table for controls #129

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add a table for controls #129

merged 1 commit into from
Aug 4, 2022

Conversation

rhmdnd
Copy link
Owner

@rhmdnd rhmdnd commented Aug 3, 2022

This table adds a basic schema for controls, which will be referenced by
results.

Ideally, this control information will supplement information from other
sources like OSCAL catalogs, which should be the preferred source of
information, since it comes from the profile/standard authors.

This schema is being discussed in issue #84.

@openshift-ci openshift-ci bot requested review from jhrozek and mrogers950 August 3, 2022 21:38
@openshift-ci openshift-ci bot added the approved label Aug 3, 2022
@jhrozek
Copy link
Collaborator

jhrozek commented Aug 4, 2022

I guess that 128 needs to go first? Either way, the DB version number needs to be bumped afterwards...

This table adds a basic schema for controls, which will be referenced by
results.

Ideally, this control information will supplement information from other
sources like OSCAL catalogs, which should be the preferred source of
information, since it comes from the profile/standard authors.

This schema is being discussed in issue #84.
@rhmdnd rhmdnd force-pushed the create-controls-table branch from 3015168 to a52579c Compare August 4, 2022 20:58
Copy link
Collaborator

@Vincent056 Vincent056 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Aug 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rhmdnd, Vincent056

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit f78eb9d into main Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants