Add a table for profiles #128
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rhmdnd
force-pushed
the
create-profile-table
branch
from
894c6cc to
8027fdb
Compare
| @@ -0,0 +1,7 @@ | |||
| CREATE TABLE IF NOT EXISTS profiles ( | |||
| id uuid PRIMARY KEY, | |||
| name VARCHAR(255), | |||
There was a problem hiding this comment.
asked a question about a control name in PR 84, from a technical perspective, this looks fine!
There was a problem hiding this comment.
I can see dropping the control name, since we can derive it from the profile (if we have a standard catalog of controls using something like OSCAL).
But for the profile, this would be a little more difficult. Because we don't want to store the entire catalog in our database (at least not yet), but we want to reference the controls in an OSCAL file. How would we link the profile here to that file?
One option would be to add a table with a text field that just stores the entire OSCAL catalog in JSON. Then we link the profile to the catalog and render the controls from the catalog.
For example, the NIST SP 800-53 is 8.7M, which should fit within a TEXT column.
There was a problem hiding this comment.
oops, sorry, I guess I commented on the wrong PR. I agree that the profile should have a name. The PR looks good, I can either ack it right away or wait for @Vincent056 to chime in.
rhmdnd
force-pushed
the
create-profile-table
branch
from
8027fdb to
58271de
Compare
|
/hold |
rhmdnd
force-pushed
the
create-profile-table
branch
from
58271de to
4b57721
Compare
|
/hold cancel |
This commit adds a table for profiles so that we can reference controls, and results to a parent profile. This table is not designed, at least initially, to store more than just a profile name and some metadata. This area will be tricky to navigate moving forward since it would be idea to rely on OSCAL defintions for profiles, and use OSCAL profiles distributed by standards bodies, and not maintain them in a service. This approach is being discussed in issue #84. Fixes #32
rhmdnd
force-pushed
the
create-profile-table
branch
from
4b57721 to
ed22900
Compare
This commit adds a table for profiles so that we can reference controls,
and results to a parent profile.
This table is not designed, at least initially, to store more than just
a profile name and some metadata. This area will be tricky to navigate
moving forward since it would be idea to rely on OSCAL defintions for
profiles, and use OSCAL profiles distributed by standards bodies, and
not maintain them in a service.
This approach is being discussed in issue #84.