-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: build coreOS with kdump RPM and run tests #62
Conversation
In an effort to reduce kdump issues, let's run our tests against their upstream repo, to catch problems earlier. See rhkdump/kdump-utils#62 Also: https://issues.redhat.com/browse/RHEL-70438
d93ffbc
to
f2ccdd5
Compare
shwrap(""" | ||
coreos-assembler init --force https://github.com/coreos/fedora-coreos-config | ||
mv kdump-coreos-ci.rpm overrides/rpm | ||
cosa fetch --with-cosa-overrides | ||
cosa build | ||
""") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine, though honestly we should probably add a e.g. rpms
argument to cosaBuild
so all this becomes cosaBuild(rpms: ['kdump-rpm'])
. Similar to the overlays
dir.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice suggestion. I don't know all the features of coreos-ci-lib (yet) 😃
edit: oh it was an improvement suggestion, I got confused !
This will uses coreOS jenkins instance to run tests on PRs for this repo.
f2ccdd5
to
b8c74fb
Compare
Hi @jbtrystram, Thanks for creating the PR! I've added github user coreosbot as an admin to this repo. Btw, is there a way to manually re-trigger the CoreOS tests for a PR? |
You need to be a member of the coreos org, but that would also give too much permissions on the coreos projects. I will look into a solution and let you know. In the meantime, you can always re-push commits to re-trigger the tests |
In an effort to reduce kdump issues, let's run our tests against their upstream repo, to catch problems earlier. See rhkdump/kdump-utils#62 Also: https://issues.redhat.com/browse/RHEL-70438
@coreosbot has accepted the invite to join this repo. coreos/coreos-ci#76 should allow anyone in the rhkdump org to cancel and retrigger jobs from the Jenkins UI. |
https://jenkins-coreos-ci.apps.ocp.fedoraproject.org/job/kdump-utils is now created and watching for PRs. But I don't think we'll be able to get the new CI to run on this PR because @jbtrystram himself is not a collaborator. But it should work on future PRs once this is merged. |
So it will only run on collaborators PRs ? |
This will uses Fedora CoreOS jenkins instance to run tests on PRs for this repo. It simply uses packit to create an RPM and build an FCOS VM image with it, then run some kdump tests.
Example of a run : https://jenkins-coreos-ci.apps.ocp.fedoraproject.org/blue/organizations/jenkins/kdump-upstream/detail/enable-coreos-ci/5/pipeline
Here are the tests being run :
Note that you need to be a members of
coreos
oropenshift
orgs to cancel or restart jobs. Maybe we need to work a better way around that.A couple items needs to be done to fully complete this :
coreosbot
as an admin to this repo : enable github hooks to report the results on PRsSee there for more details.
Also see https://issues.redhat.com/browse/RHEL-70438