Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: build coreOS with kdump RPM and run tests #62

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jbtrystram
Copy link
Contributor

@jbtrystram jbtrystram commented Dec 13, 2024

This will uses Fedora CoreOS jenkins instance to run tests on PRs for this repo. It simply uses packit to create an RPM and build an FCOS VM image with it, then run some kdump tests.

Example of a run : https://jenkins-coreos-ci.apps.ocp.fedoraproject.org/blue/organizations/jenkins/kdump-upstream/detail/enable-coreos-ci/5/pipeline

Here are the tests being run :

Note that you need to be a members of coreos or openshift orgs to cancel or restart jobs. Maybe we need to work a better way around that.

A couple items needs to be done to fully complete this :

  • add github user coreosbot as an admin to this repo : enable github hooks to report the results on PRs
  • Merge this PR to enable it on upstream CI

See there for more details.

Also see https://issues.redhat.com/browse/RHEL-70438

jbtrystram added a commit to jbtrystram/coreos-ci that referenced this pull request Dec 13, 2024
In an effort to reduce kdump issues, let's run our tests against their
upstream repo, to catch problems earlier.

See rhkdump/kdump-utils#62
Also: https://issues.redhat.com/browse/RHEL-70438
.cci.jenkinsfile Outdated Show resolved Hide resolved
.cci.jenkinsfile Show resolved Hide resolved
Comment on lines +31 to +38
shwrap("""
coreos-assembler init --force https://github.com/coreos/fedora-coreos-config
mv kdump-coreos-ci.rpm overrides/rpm
cosa fetch --with-cosa-overrides
cosa build
""")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, though honestly we should probably add a e.g. rpms argument to cosaBuild so all this becomes cosaBuild(rpms: ['kdump-rpm']). Similar to the overlays dir.

Copy link
Contributor Author

@jbtrystram jbtrystram Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice suggestion. I don't know all the features of coreos-ci-lib (yet) 😃
edit: oh it was an improvement suggestion, I got confused !

.cci.jenkinsfile Show resolved Hide resolved
This will uses coreOS jenkins instance to run tests on PRs for this repo.
@coiby
Copy link
Member

coiby commented Dec 16, 2024

Hi @jbtrystram,

Thanks for creating the PR! I've added github user coreosbot as an admin to this repo. Btw, is there a way to manually re-trigger the CoreOS tests for a PR?

@jbtrystram
Copy link
Contributor Author

Btw, is there a way to manually re-trigger the CoreOS tests for a PR?

You need to be a member of the coreos org, but that would also give too much permissions on the coreos projects. I will look into a solution and let you know.

In the meantime, you can always re-push commits to re-trigger the tests

jbtrystram added a commit to coreos/coreos-ci that referenced this pull request Dec 16, 2024
In an effort to reduce kdump issues, let's run our tests against their
upstream repo, to catch problems earlier.

See rhkdump/kdump-utils#62
Also: https://issues.redhat.com/browse/RHEL-70438
@jlebon
Copy link
Contributor

jlebon commented Dec 16, 2024

@coreosbot has accepted the invite to join this repo.

coreos/coreos-ci#76 should allow anyone in the rhkdump org to cancel and retrigger jobs from the Jenkins UI.

@jlebon
Copy link
Contributor

jlebon commented Dec 16, 2024

https://jenkins-coreos-ci.apps.ocp.fedoraproject.org/job/kdump-utils is now created and watching for PRs. But I don't think we'll be able to get the new CI to run on this PR because @jbtrystram himself is not a collaborator. But it should work on future PRs once this is merged.

@jbtrystram
Copy link
Contributor Author

jenkins-coreos-ci.apps.ocp.fedoraproject.org/job/kdump-utils is now created and watching for PRs. But I don't think we'll be able to get the new CI to run on this PR because @jbtrystram himself is not a collaborator. But it should work on future PRs once this is merged.

So it will only run on collaborators PRs ?

@coiby coiby merged commit 8a92f45 into rhkdump:main Dec 17, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants