Merge pull request #119 from rhinestonewtf/fix/uninstall-modules

hotfix: uninstall module bugs
rhinestonewtf · Jun 4, 2024 · c1e231e · c1e231e
2 parents a30c9a0 + 757e1d5
commit c1e231e
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,7 +4,8 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Common Changelog](https://common-changelog.org/).
 
-[0.4.3]: https://github.com/rhinestonewtf/modulekit/releases/tag/v0.4.4
+[0.4.5]: https://github.com/rhinestonewtf/modulekit/releases/tag/v0.4.5
+[0.4.4]: https://github.com/rhinestonewtf/modulekit/releases/tag/v0.4.4
 [0.4.3]: https://github.com/rhinestonewtf/modulekit/releases/tag/v0.4.3
 [0.4.2]: https://github.com/rhinestonewtf/modulekit/releases/tag/v0.4.2
 [0.4.1]: https://github.com/rhinestonewtf/modulekit/releases/tag/v0.4.1
@@ -24,6 +25,12 @@ The format is based on [Common Changelog](https://common-changelog.org/).
 
 ### Fixed
 
+- Bugs in uninstall module functions
+
+## [0.4.4] - 04-06-2024
+
+### Fixed
+
 - Specify correct Kernel version
 - Dependency based CI
 

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@rhinestone/modulekit",
-  "version": "0.4.4",
+  "version": "0.4.5",
   "description": "A development kit for building and testing smart account modules.",
   "license": "GPL-3.0",
   "author": {

diff --git a/remappings.txt b/remappings.txt
@@ -18,4 +18,4 @@ solady/=node_modules/solady/src/
 solarray/=node_modules/solarray/src/
 @prb/math/=node_modules/@prb/math/src/
 kernel/=node_modules/@zerodev/kernel/src/
-ExcessivelySafeCall/=node_modules/excessively-safe-call/src/
+ExcessivelySafeCall/=node_modules/excessively-safe-call/src/
diff --git a/src/test/utils/ERC7579Helpers.sol b/src/test/utils/ERC7579Helpers.sol
@@ -359,9 +359,8 @@ library ERC7579Helpers {
         pure
         returns (bytes memory callData)
     {
-        callData = abi.encodeCall(
-            IERC7579Account.uninstallModule, (MODULE_TYPE_HOOK, address(0), initData)
-        );
+        callData =
+            abi.encodeCall(IERC7579Account.uninstallModule, (MODULE_TYPE_HOOK, hook, initData));
     }
 
     /**
@@ -395,7 +394,7 @@ library ERC7579Helpers {
     {
         fallbackHandler = fallbackHandler; //avoid solhint-no-unused-vars
         callData = abi.encodeCall(
-            IERC7579Account.uninstallModule, (MODULE_TYPE_FALLBACK, address(0), initData)
+            IERC7579Account.uninstallModule, (MODULE_TYPE_FALLBACK, fallbackHandler, initData)
         );
     }