Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awake wav mic mute settings #91

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

Ranger2959
Copy link
Contributor

Adds two new settings:

  • "--mic-seconds-to-mute-after-awake-wav" - seconds to mute mic after awake wav is played.
  • "--mic-mute-during-awake-wav" - true/false if mic should be muted while awake-wav is played.

Copy link
Contributor

@llluis llluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You seem to be missing some commits? You add the settings but don't use them anywhere?!...

@Ranger2959
Copy link
Contributor Author

You seem to be missing some commits? You add the settings but don't use them anywhere?!...

This PR just sets up the use of these two variables for use on the command line when running a wyoming-satellite. Once passed in, they are use accordingly from the MicSettings class.

Where else are you expecting them to be used in the repo?

@llluis
Copy link
Contributor

llluis commented Jan 28, 2024

You pass those two settings in the command line and they will be stored in the MicSettings class. However, you are not reading them anywhere, so, there are not being used.

There's no action in the satellite to use them and mute the mic.
So, even if you run the satellite with 10s in this parameter, they will be ignored and no mute will be done.

@Ranger2959
Copy link
Contributor Author

You pass those two settings in the command line and they will be stored in the MicSettings class. However, you are not reading them anywhere, so, there are not being used.

There's no action in the satellite to use them and mute the mic. So, even if you run the satellite with 10s in this parameter, they will be ignored and no mute will be done.

mute_during_awake_wav is already used here:

mute_microphone=self.settings.mic.mute_during_awake_wav,

seconds_to_mute_after_awake_wav is already used here:

seconds_to_mute += self.settings.mic.seconds_to_mute_after_awake_wav

Copy link
Contributor

@llluis llluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are absolutely right, sorry. As per the notes in the PR I was expecting this to be new parameters, I wasn't expecting it was just exposing exiting one which was hardcoded in the settings.

@synesthesiam
Copy link
Contributor

Thanks!

@synesthesiam synesthesiam merged commit 12cce8e into rhasspy:master Jan 30, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants