This repository has been archived by the owner on Jun 21, 2023. It is now read-only.
Fix issues to enable Windows support #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I tried installing and running the package on Windows and encountered several issues. Fortunately, none of them were truly serious and I managed to get it (almost) fully working (both CLI and server) with some patches:
phonemes2ids1.0.0fails to install on Windows. Upgrading the dependency to1.2.0fixed it.server.py:_LOOP.add_signal_handler(signal.SIGTERM, _signal_handler)is not supported on Windows (gettingNotImplementedError). Ignoring this error works around the issue. I tested that CTRL+C still aborts the server, although it may not do it as cleanly as with a handler.utils.py,with tempfile.NamedTemporaryFile(mode="wb+" ...opens a temporary file in write mode. Latershutil.unpack_archiveattempts to reopen the file while it is still opened for writing. This works on Linux, but not on Windows (unless the secondary opener passes a special low level flag to enable sharing of this sort). I worked around the issue by closing the file and later deleting it in afinallyclause.Other Windows issues:
playcommand (it falls back to saving awavfile but unfortunately, thewavfile contains only the last sentence when the text includes multiple sentences).nulland gets a404error? I'm not sure why this happens but it doesn't seem to impact anything (edit: it only happens when using the web interface, not when requesting from the REST api, so I'm not sure it is platform-specific).I'm really happy to be able to run this directly on Windows. Having to use WSL or docker isn't very convenient, and makes it difficult/impossible to import it as a library.
Please let me know if there's anything I've missed.