MGMT-19314: remove static network from image-based-installation-config.yaml

[tsorya]

MGMT-19314: remove static network from image-based-installation-config.yaml

We don't want to validate static networking in this part as it is less critical and requires different configurations for IBI and IBIO as IBIO runs with dev-scripts network.
Till now static network was failing and we dropped to dhcp, from this point we will just go with dhcp

Summary by CodeRabbit

• Bug Fixes
  • Removed the networkConfig section from the installation configuration template, streamlining network configuration handling.

[eranco74]

@coderabbitai summary

[eranco74]

@coderabbitai review

[eranco74]

@coderabbitai review

[eranco74]

@coderabbitai review

[romfreiman]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[coderabbitai]

Walkthrough

The pull request involves removing the networkConfig section from the image-based-installation-config-template.yaml file. This change suggests a modification in how network configurations are defined and managed within the image-based installation configuration template. The removal of the network interface details indicates a potential shift in network configuration approach, though the specific reasons or implications are not detailed in the provided summary.

Changes

File	Change Summary
image-based-installation-config-template.yaml	Removed networkConfig section that previously defined network interface eth0 with its properties

Sequence Diagram

graph TD
    A[Configuration Template] --> B{Network Configuration}
    B -->|Before| C[Explicit Network Interface Definition]
    B -->|After| D[Network Configuration Removed]

Loading

The diagram illustrates the transition from an explicit network interface definition to a state where network configuration is no longer directly specified in the template.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1e8ab14 and 2b9e3f5.

📒 Files selected for processing (1)

• image-based-installation-config-template.yaml (0 hunks)

💤 Files with no reviewable changes (1)

• image-based-installation-config-template.yaml

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.