Get ETag as LWT promise #267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the static middlewares' ETag argument from `?etag_of_fname:(string -> string option)` to `?etag_of_fname:(string -> string option Lwt.t)`. This change was proposed in rgrinberg#265.
|
LGTM, can you add an entry in the changelog? |
|
I pushed a proposal for the timestamp thing. On my end, Github does not show the latests commits as part of this PR. See pkel@342d7b6 Changelog entry in pkel@98baec5 |
|
Thanks! |
anuragsoni
pushed a commit
that referenced
this pull request
Nov 20, 2021
* Get ETag as LWT promise This commit changes the static middlewares' ETag argument from `?etag_of_fname:(string -> string option)` to `?etag_of_fname:(string -> string option Lwt.t)`. This change was proposed in #265. * Generate ETag from UNIX file system * Update CHANGES.md * ocamlformat my changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the static middlewares' ETag argument from
?etag_of_fname:(string -> string option)to?etag_of_fname:(string -> string option Lwt.t).This change was proposed in #265.