several fixes, checked for portability

[hannesdatta]

• Checked for portability on two other Windows systems
• Removed any \gen files from tracking (these are GENERATED, hence, they need not be tracked)
• Saved .gitkeep in the remaining (empty) dir structure to initialize directories
• Added any remaining files that need not be tracked to .gitignore

Very good work, Rafael!

To do's:

• the clean rule in makefile doesn't work - took it out from ALL
• add link to Tex installation to your readme - alternatively, add an instruction page for installation to tilburgsciencehub via a PR on Git?
• the \ in make look weird. really required? Hard for people to read.
• Ensure compatibility w/ Linux and Mac; pending...

[rgreminger]

Hi Hannes,

I just saw this now, probably should have held off with the release.. Thanks for the changes, they're very helpful! It definitely makes sense to use .gitkeep files to keep the folder structure, I was actually not aware of this option. The same goes with the clean rule. That one I'll have to fix anyways to make it platform independent, from what I understand it's the only part that won't work on other platforms than Windows.

But I'd remove the input folders, since with larger datasets this can eat up disk space quickly. For now added them in there from your PR, so it's consistent with the page (I've also opened an issue ).

The other things you mentioned I'll open separate issues for them. Will try to fix them in the coming days.
Best,
Rafael

[hannesdatta]

Uhhh, yeah. I completely forgot about these input folders. These need to be fixed, indeed. Why don't we use an r script to delete and create folders/files? That'll make it platform independent immediately. die.create() unlink() list.files() Keep it up. Cheers, H. Outlook voor Android downloaden<https://aka.ms/ghei36>

…

________________________________ From: rgreminger <[email protected]> Sent: Thursday, March 5, 2020 12:23:52 AM To: rgreminger/example-make-workflow <[email protected]> Cc: Hannes Datta <[email protected]>; Author <[email protected]> Subject: Re: [rgreminger/example-make-workflow] several fixes, checked for portability (#2) Merged #2<#2> into master. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#2?email_source=notifications&email_token=AD6KNIXSQRDV6MNH4TN4CSDRF3PILA5CNFSM4LBRINLKYY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOXC3T74A#event-3099017200>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AD6KNIVDZS7PHFA32WI5ZZTRF3PILANCNFSM4LBRINLA>.