-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use one base class for plain_coap and coap #86
base: master
Are you sure you want to change the base?
Conversation
To just see changes from this PR, have a look at Cyber1000/py-air-control@master...Cyber1000:coap |
Thanks, I have merged #85, please rebase. |
rebased and tested (with coap) |
Thanks! I wish someone can confirm if this works with plain coap before merging. |
@shexbeer Could you please test this PR with your device? We want to make sure this change won't break the support for plain_coap. Thanks! |
Since plain_coap has some similarities to coap (except the AES-encryption) I now use a common base between these two. That will also reduce the changes involved moving to another coap-libary (for example aiocoap) in the near future.
Tested with coap, need someone testing this with plain_coap
Depends on #85 (including commits from there), so should be merged afterwards