add config_parser in trainer_config_helpers to seperate trainer config #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… develop_test Synchronize code from PaddlePaddle/Paddle
reyoung
requested changes
Dec 22, 2016
| @@ -0,0 +1,38 @@ | |||
| # Copyright (c) 2016 PaddlePaddle Authors. All Rights Reserved | |||
There was a problem hiding this comment.
换一个文件名吧？这个文件名感觉已经被使用过了。
类似于config_parser_utils.py就好了
|
|
||
|
|
||
| def parse_network_config(network_conf): | ||
| config = config_parser.parse_config(network_conf, '') |
There was a problem hiding this comment.
这个config_arg_str还是给暴露出来吧。可以把默认参数设置成''。即
def parse_network_config(network_conf, config_arg_str=None):
if config_arg_str is None:
config_arg_str = ''
...这个参数比较有用。
|
|
||
|
|
||
| def parse_optimizer_config(optimizer_conf): | ||
| config = config_parser.parse_config(optimizer_conf, '') |
Change float to real in NormLayer.h
* Make this demo support GPU
…nto feature/mnist_train_api
…nto feature/mnist_train_api
|
我自己的分支更新了，如果反馈到这里来 |
|
@jacquesqiao 似乎是rebase过版本，导致修改的版本太多了。。 我直接从你的repo里面，cherry pick修改的版本吧。 |
|
@jacquesqiao 我已经手动加到这个分支里了。这个PR就先关了。 |
reyoung
pushed a commit
that referenced
this pull request
Sep 6, 2017
Invoke check_grad many times for no_grad_set
reyoung
pushed a commit
that referenced
this pull request
Sep 19, 2017
reyoung
pushed a commit
that referenced
this pull request
Oct 16, 2017
reyoung
pushed a commit
that referenced
this pull request
Dec 4, 2017
fix pipe_reader unimport packages
reyoung
pushed a commit
that referenced
this pull request
May 17, 2018
Merge branch 'develop' of https://github.com/PaddlePaddle/Paddle
reyoung
pushed a commit
that referenced
this pull request
Dec 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
写了一个初步版本，看看是否符合你的预期。