Update optimizer path #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 7, 2024 15:45
|
Good catch. The only change I would make is that I would put a reference to the ikeras ssue in a comment right above the changed line in the code, and not just in the description in this PR, so it will be more obvious to future readers of the code why it was done that way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tiny modification to the path to the Adam optimizer which fixed the issue of deserializing a tf==2.14.1 model on a mac with an M1 chip. This is needed to make this PR work, which is currently running inference with a test model using this new optimizer path. I will kick off a full retraining run now with this fix.
Issue and solution described here.