Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add .vscode file to autorun prettier #29

Closed
wants to merge 1 commit into from
Closed

Conversation

RandomEtc
Copy link
Member

No description provided.

@vercel
Copy link

vercel bot commented Oct 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
embed-rewiringamerica-org ✅ Ready (Inspect) Visit Preview Oct 2, 2023 7:19pm

@RandomEtc
Copy link
Member Author

@oyamauchi let me know your thoughts here.

Mine:

  • the lint-staged husky config to check edited files with prettier should help moving forward
  • if you don't like the idea of opinionated VS Code configs, I think we should be more urgently adding prettier and other linters as required CI steps (especially in advance of open sourcing)
  • this might be an and thing

@oyamauchi
Copy link
Member

I just put up #32 to add prettier/eslint/tsc as a CI step, so maybe that addresses this?

The reason I generally don't commit vscode config is that this will prevent people from setting their own workspace-specific config. (Actually, I usually gitignore .vscode entirely.)

In this case I don't have workspace-specific config, so landing this wouldn't bother me and I won't die on this hill. But I'd prefer not to do it.

@RandomEtc
Copy link
Member Author

Closing in favor of local config and #32.

@RandomEtc RandomEtc closed this Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants