Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated v1 items #161

Merged
merged 2 commits into from
May 22, 2024
Merged

Remove deprecated v1 items #161

merged 2 commits into from
May 22, 2024

Conversation

oyamauchi
Copy link
Member

Description

The backend is about to stop supporting these items, so don't send them up.

Test Plan

Ran against local backend with and without the change that removes
these items; make sure the results are the same (for HVAC and
weatherization projects) in both cases, and there are no errors.

## Description

The backend is about to stop supporting these items, so don't send them up.

## Test Plan

Ran against local backend with and without the change that removes
these items; make sure the results are the same (for HVAC and
weatherization projects) in both cases, and there are no errors.
Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
embed-rewiringamerica-org ✅ Ready (Inspect) Visit Preview May 22, 2024 6:38pm

Copy link
Contributor

@matelau matelau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is to be expected that Cypress tests are failing atm? Otherwise LGTM.

@oyamauchi
Copy link
Member Author

They're expected to fail until I do a backend deploy. I won't merge until they're passing.

@oyamauchi oyamauchi merged commit 0cedf32 into main May 22, 2024
3 checks passed
@oyamauchi oyamauchi deleted the owen.rm-items branch May 22, 2024 18:42
@matelau
Copy link
Contributor

matelau commented May 22, 2024

They're expected to fail until I do a backend deploy. I won't merge until they're passing.

Great, I thought so, but just wanted to check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants