A few more item groups #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description
After going through all the existing incentives and giving them more
granular items, I found some common combinations that are worth
handling: door/window replacement, and audits plus weatherization.
There was one combined incentive (CO's state tax credit for air source
heat pumps and HPWHs) which I elected to split into two incentives; it
felt too awkward to create a group for those technologies.
## Test Plan
Unit test.
I found all the multi-item combos in the incentives data by running
this in the incentives repo:
`echo data/**/incentives.json | xargs jq '.[] | select((.items | length) > 1) | .items | sort | join(",")' | sort | uniq`
All the resulting combos are now handled in here.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
matelau
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After going through all the existing incentives and giving them more
granular items, I found some common combinations that are worth
handling: door/window replacement, and audits plus weatherization.
There was one combined incentive (CO's state tax credit for air source
heat pumps and HPWHs) which I elected to split into two incentives; it
felt too awkward to create a group for those technologies.
Test Plan
Unit test.
I found all the multi-item combos in the incentives data by running
this in the incentives repo:
echo data/**/incentives.json | xargs jq '.[] | select((.items | length) > 1) | .items | sort | join(",")' | sort | uniqThere are no combos in there that will result in null here.