Send email-required flag to signup endpoint #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Description We'll want to track this along with signups to measure the effect of requiring email. This will require a followup to Zuplo to read this param and send it to SFMC. ## Test Plan Sign up under both conditions, make sure the flag is present and with the correct value in network inspector. (Zuplo isn't reading the flag yet so nothing will change in SFMC.)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kylehotchkiss
approved these changes
Feb 28, 2024
|
Not yet, but I have verified the value successfully gets to Zuplo, so I'm going to go ahead and land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We'll want to track this along with signups to measure the effect of
requiring email. This will require a followup to Zuplo to read this
param and send it to SFMC.
Test Plan
Sign up under both conditions, make sure the flag is present and with
the correct value in network inspector. (Zuplo isn't reading the flag
yet so nothing will change in SFMC.)