Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code cleanup #155

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Code cleanup #155

wants to merge 6 commits into from

Conversation

AlexKurek
Copy link

No description provided.

revoltek
revoltek reviewed May 15, 2024
View reviewed changes
Copy link
Owner

@revoltek revoltek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the create_array here is necessary to create the array with the axis values, the returned axis is not used but data are saved

gmloose
gmloose reviewed May 15, 2024
View reviewed changes
losoto/lib_unwrap.py
Comment on lines 44 to 49
i = 0
if iterations < 1:
interations = 1
# if iterations < 1:
# interations = 1
while i < iterations:
i += 1
phase2D = phaseUnwrapper(phase2D)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this could/should be rewritten to:

for _ in range(iterations):
    phase2D = phaseUnwrapper(phase2D)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmloose gmloose gmloose left review comments

@revoltek revoltek revoltek left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AlexKurek @revoltek @gmloose