Fix suggestions with multiple corrections #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfittko
force-pushed
the
fix-suggestions
branch
from
849d8bb
to
892a6f7
Compare
|
We're using this branch now as we think that the change is working well. Unfortunately this is not well covered by tests (yet) though, so if someone is able to help ot there, feel free to reach out. Anyone who's relying on this, feel free to use our fork's branch until this is merged. If you see any issues, please post them here. |
|
@haya14busa I think I fixed the issue and verified with a local devcontainer setup (see PR #130 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The suggestions feature is broken as it's ignoring any offenses with multiple corrections. This is leading to wrong or - at best - incomplete sugggestions.
Fixes #81 and #96
Examples (before fix):
Examples (with fix):
