-
-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): Fix CI for Onivim 2 - revert fetch dependencies #997
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @bryphe, sorry to see that there are issues. Definitely revert if this is blocking you in Oni2. I'm in the midst of a move so not a lot of time to debug, but it looks a bit odd! I like the idea of using luv under the hood, it's something I've experimented with briefly but would definitely need to read up a bit on SSL!
Perhaps @ulrikstrid has some ideas?
In theory you can run lwt with luv. If I remember I can look at the build error tomorrow. |
Thanks for being so understanding, @lessp !
Good luck with the move! Ya, SSL + luv would be awesome 💯
Cool, maybe not too far off. Can't wait until I can ditch the node-download-strategy for something w/ native reason. Will simplify things a lot. |
Fixes #474 Depends on revery-ui/revery#995 and revery-ui/revery#997
Unfortunately, I'm still seeing issues with the set of dependencies for the
fetch-lwt
library, when building Onivim 2 - we get this error:I've been trying to avoid reverting this, and maintaining a separate 'oni2' branch w/o it - but it's a lot of extra overhead for me (we can't actually use
fetch
in Onivim 2, either - lack of Windows support & it isn't integrated with libuv).When building from Onivim 2, I get these errors:
I'd definitely like to have the
fetch
API - some details here: #996 , and really appreciate all the pioneering work you've done @lessp ! If you have any other ideas, @lessp - let me know 👍