Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): Fix CI for Onivim 2 - revert fetch dependencies #997

Merged
merged 10 commits into from
Sep 1, 2020

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Aug 31, 2020

Unfortunately, I'm still seeing issues with the set of dependencies for the fetch-lwt library, when building Onivim 2 - we get this error:

I've been trying to avoid reverting this, and maintaining a separate 'oni2' branch w/o it - but it's a lot of extra overhead for me (we can't actually use fetch in Onivim 2, either - lack of Windows support & it isn't integrated with libuv).

When building from Onivim 2, I get these errors:

Bryans-Mac-mini:oni2 bryphe$ esy run -f
info building @reason-native-web/[email protected]@d41d8cd9
error: build failed with exit code: 1
  build log:
    # esy-build-package: building: @reason-native-web/[email protected]
    # esy-build-package: pwd: /Users/bryphe/.esy/source/i/reason_native_web__s__piaf__1.3.0__aac2317a
    # esy-build-package: running: 'dune' 'build' '--only-packages=piaf' '--profile=release' '-j' '4' '--root=./piaf'
    Entering directory '/Users/bryphe/.esy/source/i/reason_native_web__s__piaf__1.3.0__aac2317a/piaf'
    File "lib/http_intf.ml", line 1:
    Error: The files lib/.piaf.objs/byte/piaf__Scheme.cmi
           and /Users/bryphe/.esy/3__________________________________________________________________/i/reason_native_web__s__h2_lwt_unix-0.6.1000-eb9002c6/lib/h2-lwt-unix/h2_lwt_unix.cmi
           make inconsistent assumptions over interface Gluten_lwt_unix__Ssl_io
    error: command failed: 'dune' 'build' '--only-packages=piaf' '--profile=release' '-j' '4' '--root=./piaf' (exited with 1)
    esy-build-package: exiting with errors above...
    
  building @reason-native-web/[email protected]
esy: exiting due to errors above

I'd definitely like to have the fetch API - some details here: #996 , and really appreciate all the pioneering work you've done @lessp ! If you have any other ideas, @lessp - let me know 👍

Copy link
Member

@lessp lessp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @bryphe, sorry to see that there are issues. Definitely revert if this is blocking you in Oni2. I'm in the midst of a move so not a lot of time to debug, but it looks a bit odd! I like the idea of using luv under the hood, it's something I've experimented with briefly but would definitely need to read up a bit on SSL!

Perhaps @ulrikstrid has some ideas?

@ulrikstrid
Copy link
Contributor

In theory you can run lwt with luv.

If I remember I can look at the build error tomorrow.

@bryphe
Copy link
Member Author

bryphe commented Sep 1, 2020

Thanks for being so understanding, @lessp !

I'm in the midst of a move so not a lot of time to debug, but it looks a bit odd! I like the idea of using luv under the hood, it's something I've experimented with briefly but would definitely need to read up a bit on SSL!

Good luck with the move! Ya, SSL + luv would be awesome 💯

In theory you can run lwt with luv.

Cool, maybe not too far off. Can't wait until I can ditch the node-download-strategy for something w/ native reason. Will simplify things a lot.

@bryphe bryphe merged commit 11d4fb4 into master Sep 1, 2020
@bryphe bryphe deleted the fix/ci/revert-fetch branch September 1, 2020 15:16
bryphe added a commit to onivim/oni2 that referenced this pull request Sep 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants