Modify test case to account for changes

retrry · Oct 20, 2024 · 255de61 · 255de61
1 parent 35d2977
commit 255de61
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/...entelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py b/...entelemetry-instrumentation-fastapi/src/opentelemetry/instrumentation/fastapi/__init__.py
@@ -409,6 +409,10 @@ def _get_route_details(scope, app=None):
     """
     Function to retrieve the full route path, handling mounted sub-applications (Mount) recursively.
 
+    TODO: there is currently no way to retrieve http.route from
+    a starlette application from scope.
+    See: https://github.com/encode/starlette/pull/804
+
     Args:
         scope: A FastAPI/Starlette scope
         app: The FastAPI/Starlette app or sub-app (defaults to the app in scope)

diff --git a/instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py b/instrumentation/opentelemetry-instrumentation-fastapi/tests/test_fastapi_instrumentation.py
@@ -230,8 +230,7 @@ def test_sub_app_fastapi_call(self):
         spans = self.memory_exporter.get_finished_spans()
         self.assertEqual(len(spans), 3)
         for span in spans:
-            # As we are only looking to the "outer" app, we would see only the "GET /sub" spans
-            self.assertIn("GET /sub", span.name)
+            self.assertIn("GET /sub/home", span.name)
 
         # We now want to specifically test all spans including the
         # - HTTP_TARGET