This repository has been archived by the owner on May 7, 2022. It is now read-only.
Potential fix for unittest RDBBtree.SindexInterruptionViaDrop failure #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unittest RDBBtree.SindexInterruptionViaDrop was failing due to this bug in clear_sindex_data.
|
This looks fine to me conceptually. Could you see why checks are failing? |
|
The details of both failing checks don't seem to be working. Have these bee updated recently? |
|
We need to ensure that the checks are not failing due to any unintended change here |
|
The links to the tests are incorrect. They still point to https://app.shippable.com/github/rethinkdb/rethinkdb/runs/1/1/console I can write a fix for this PR maybe which'll fix this |
|
Here is an updated tests link. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RDBBtree.SindexInterruptionViaDrop had been failing at the guarantee in
txn_t::~txn_t.I managed to track the issue down to
store_t::clear_sindex_datanot committing the transaction before returning. This patch adds transaction commit tostore_t::clear_sindex_dataandstore_t::drop_sindex.While this does fix the unit test failing, could someone with a more complete understanding of the code make sure this is right and does no suffer from any bad side affects which I'm unaware of thanks.