Skip to content

Commit

Permalink
Fix slice collectors to leaves association with post filter (opensear…
Browse files Browse the repository at this point in the history
…ch-project#11134) (opensearch-project#11150)

* Fix slice collectors to leaves association with profile enabled (opensearch-project#11134)



* Update server/src/main/java/org/opensearch/search/profile/query/ConcurrentQueryProfileBreakdown.java





---------




(cherry picked from commit 3eda422)

Signed-off-by: Ticheng Lin <[email protected]>
Signed-off-by: Ticheng Lin <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <[email protected]>
  • Loading branch information
3 people authored Nov 10, 2023
1 parent 32b90a2 commit 822e253
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@
import org.apache.lucene.search.Weight;
import org.apache.lucene.util.Bits;
import org.opensearch.common.lucene.Lucene;
import org.opensearch.search.profile.query.ProfileWeight;

import java.io.IOException;

Expand All @@ -64,6 +65,9 @@ public Collector getCollector() {

@Override
public LeafCollector getLeafCollector(LeafReaderContext context) throws IOException {
if (filter instanceof ProfileWeight) {
((ProfileWeight) filter).associateCollectorToLeaves(context, collector);
}
final ScorerSupplier filterScorerSupplier = filter.scorerSupplier(context);
final LeafCollector in = collector.getLeafCollector(context);
final Bits bits = Lucene.asSequentialAccessBits(context.reader().maxDoc(), filterScorerSupplier);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,10 @@ public Map<String, Long> toBreakdownMap() {
// creates a new weight and breakdown map for each rewritten query. This new breakdown map captures the timing information for
// the new rewritten query. The sliceCollectorsToLeaves is empty because this breakdown for rewritten query gets created later
// in search leaf path which doesn't have collector. Also, this is not needed since this breakdown is per leaf and there is no
// concurrency involved. An empty sliceCollectorsToLeaves could also happen in the case of early termination.
// concurrency involved.
assert contexts.size() == 1 : "Unexpected size: "
+ contexts.size()
+ " of leaves breakdown in ConcurrentQueryProfileBreakdown of rewritten query for a leaf.";
AbstractProfileBreakdown<QueryTimingType> breakdown = contexts.values().iterator().next();
queryNodeTime = breakdown.toNodeTime() + createWeightTime;
maxSliceNodeTime = 0L;
Expand Down

0 comments on commit 822e253

Please sign in to comment.