Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ResourceException: avoid NotSerializableException #1403

Merged
merged 2 commits into from
Jan 26, 2024

Conversation

tomas-muller
Copy link

tomas-muller and others added 2 commits May 9, 2023 19:09
- non-serializable internal attributes (status, request, and message) marked as transient
- this is to allow ResourceException to be serialized, passing over the message and stack-trace (which is typically all that is needed to show the error or print it in the log)
- fixes issue restlet#1402
Disclaimer needed now that default serialization silently works.
@Tembrel
Copy link
Collaborator

Tembrel commented May 9, 2023

Added a disclaimer to the ResourceException class comment, as discussed in #1402.

@thboileau
Copy link
Contributor

thboileau commented Jan 6, 2024

hi @tomas-muller
Thanks a lot for your contribution!
As a first-time contributor, do you mind to sign this JCA document?

@tomas-muller
Copy link
Author

hi @tomas-muller Thanks a lot for your contribution! As a first-time contributor, do you mind to sign this JCA document?

Hi @thboileau, I have no problem signing a contributor license agreement, however, the link Joint Copyright Assignment (JCA) does not work. Is there an alternative location or can you email it to me at [email protected]? Thanks.

@thboileau
Copy link
Contributor

oh I see. Let me check. I'll come back to you

@thboileau
Copy link
Contributor

hi @tomas-muller
Sorry for the delay. here is the JCA
you can sign it and return it to [email protected] ?

@tomas-muller
Copy link
Author

hi @tomas-muller Sorry for the delay. here is the JCA you can sign it and return it to [email protected] ?

Hi @thboileau. This is done. Thank you!

@thboileau thboileau merged commit f7b9056 into restlet:2.4 Jan 26, 2024
@thboileau
Copy link
Contributor

thanks @tomas-muller it will be part of the incoming 2.4.4 version and 2.5.0 version of the framework

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants