Fix a crash in multipartBodyParser if mapping files array #1819 #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retrohacker
requested changes
Apr 1, 2020
| }); | ||
| }); | ||
| } | ||
|
|
||
| barrier.start('fs' + f); |
There was a problem hiding this comment.
Thanks for the contribution @guoyibj!
I'm not super familiar with this piece of code. But it looks like we are trying to flatten the array here. This if condition doesn't look like it returns and the following barrier is still run against f. Is that intentional?
Would it be possible to flatten files first? I.E. convert [f1, f2, [f3, [f4]]] to [f1, f2, f3, f4] to avoid the conditional logic here?
ghermeto
requested changes
Jun 27, 2020
There was a problem hiding this comment.
Hi @guoyibj, thank you for contributing.
If you always cast files[f] to an Array you avoid have two code paths.
I also tried to run the tests without your changed and they passed. Could you include tests that will fail without your changes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pre-Submission Checklist
make prepushIssues
Closes:
Crash in multipartBodyParser if mapping files array
Changes
Fix the crash issue and add test code.