Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bodyReader works with gunzip and maxBodySize #1787

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jfilipczyk
Copy link

Pre-Submission Checklist

  • Opened an issue discussing these changes before opening the PR
  • Ran the linter and tests via make prepush
  • Included comprehensive and convincing tests for changes

Issues

Closes:

Changes

Adds error handling for Gunzip errors so node process does not die.
Fixes handling "413 Payload Too Large" for gzip encoded content.

@sergburn
Copy link

sergburn commented Sep 10, 2020

Dear maintainers, please review this and approve!
It's a pity that Restify may be crashed just by setting Content-Encoding: gzip and POST-ing plain text body.

One workaround is server.on('uncaughtException', but it's bad and deprecated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants