Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output status of append only mode on startup #295

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

rawtaz
Copy link
Contributor

@rawtaz rawtaz commented Jul 28, 2024

What is the purpose of this change? What does it change?

Previously, rest-server did not output whether append only mode
was enabled or disabled when starting up. The status of private
repositories was however output.

Since private repositories and append only are two important
settings that are directly related to the security of the rest-server
instance, it seems prudent to also output the status of append only.

Was the change discussed in an issue or in the forum before?

No, I was just missing it in the output when setting up a new rest-server
instance in append-only mode.

Checklist

  • I have enabled maintainer edits for this PR
  • I have added tests for all changes in this PR
  • I have added documentation for the changes (in the manual)
  • There's a new file in changelog/unreleased/ that describes the changes for our users (template here)
  • I have run gofmt on the code in all commits
  • All commit messages are formatted in the same style as the other commits in the repo
  • I'm done, this Pull Request is ready for review

Copy link
Member

@MichaelEischer MichaelEischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fine with me.

@MichaelEischer MichaelEischer merged commit e35c6e3 into master Jul 29, 2024
5 checks passed
@MichaelEischer MichaelEischer deleted the append-only-status branch July 29, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants