Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable TRACE for bifrost and log-server #19

Merged
merged 1 commit into from
Nov 11, 2024
Merged

Enable TRACE for bifrost and log-server #19

merged 1 commit into from
Nov 11, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Nov 11, 2024 •
edited
Loading

No description provided.

@AhmedSoliman
Copy link
Contributor Author

Do we need to release/publish something in order for this to be effective in restate CI builds?

tillrohrmann
tillrohrmann approved these changes Nov 11, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging. I think we are needing a new sdk-test-suite release and have to update the SDK repos to use the new release to see these changes in our tests.

@AhmedSoliman AhmedSoliman merged commit 5f6917a into main Nov 11, 2024
2 checks passed
@slinkydeveloper slinkydeveloper deleted the pr19 branch November 11, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

@slinkydeveloper slinkydeveloper Awaiting requested review from slinkydeveloper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AhmedSoliman @tillrohrmann