[Mechanical] Rename ReplicatedLogletId to LogletId #2450
Merged
+343
−270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the new parameter to appender's API to let API users control the behaviour when appends to the current loglet face persistent failures. There is a new feature (`auto-extend` in restate-bifrost which controls the default behaviour). No logic changes happen in this PR, in future PRs, bifrost will respect this input and will configure its behaviour accordingly.
Summary: Moves ReplicatedLogletId to be a common helper type for all loglets that want to benefit from its internal structure. The changes are mechanical since the type now is in `restate_types::logs` instead being specific under replicated_loglet. Test Plan: Unit tests
muhamadazmy
approved these changes
Dec 23, 2024
There was a problem hiding this comment.
Thanks @AhmedSoliman for this rename, it makes sense to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Moves ReplicatedLogletId to be a common helper type for all loglets that want to benefit from its internal structure. The changes are mechanical since the type now is in
restate_types::logsinstead being specific under replicated_loglet.Test Plan: Unit tests
Stack created with Sapling. Best reviewed with ReviewStack.