Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve error messages #2442

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve error messages #2442

wants to merge 1 commit into from
+51 −27

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper
Improve error messages:
aec443b 
* Add response headers to bad discovery response. Fix restatedev#2369
* Improve connect error in ServiceClient
AhmedSoliman
AhmedSoliman reviewed Dec 23, 2024
View reviewed changes
crates/service-client/src/http.rs
#[error(transparent)]
Http(#[from] http::Error),
#[error("server possibly only supports HTTP1.1, consider discovery with --use-http1.1: {0}")]
#[error("server possibly only supports HTTP1.1, consider discovery with --use-http1.1.\nReason: {}", FormatHyperError(.0))]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure about \n in those messages, but let's give this a try and see how what comes out of it.

@AhmedSoliman AhmedSoliman self-requested a review December 23, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkleeman jackkleeman jackkleeman approved these changes

@AhmedSoliman AhmedSoliman AhmedSoliman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When running discovery, print back the response headers
3 participants
@slinkydeveloper @AhmedSoliman @jackkleeman