Add compensations example to Typescript and Java patterns #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
issues/52
branch
from
59c5522 to
7d802c8
Compare
gvdongen
reviewed
Jan 22, 2024
gvdongen
approved these changes
Jan 22, 2024
java/patterns/src/main/java/dev/restate/patterns/Compensations.java
Outdated
Show resolved
Hide resolved
java/patterns/src/main/java/dev/restate/patterns/Compensations.java
Outdated
Show resolved
Hide resolved
java/patterns/src/main/java/dev/restate/patterns/Compensations.java
Outdated
Show resolved
Hide resolved
pcholakov
reviewed
Jan 23, 2024
java/patterns/src/main/java/dev/restate/patterns/Compensations.java
Outdated
Show resolved
Hide resolved
java/patterns/src/main/java/dev/restate/patterns/Compensations.java
Outdated
Show resolved
Hide resolved
tillrohrmann
force-pushed
the
issues/52
branch
from
7d802c8 to
e1a2de9
Compare
|
Thanks a lot for your review @gvdongen, @slinkydeveloper and @pcholakov. I've addressed your comments. Will merge the PR once GHA gives green light. |
tillrohrmann
force-pushed
the
issues/52
branch
2 times, most recently
from
f913b4a to
b1754b2
Compare
java/patterns/src/test/java/dev/restate/patterns/CompensationsTest.java
Outdated
Show resolved
Hide resolved
tillrohrmann
force-pushed
the
issues/52
branch
from
b1754b2 to
c7c99fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an example for how to use compensations to leave the system in a consistent state in the presence of terminal exceptions (cancellations and deliberate usage of it). The example was added to the TS patterns and the newly created Java patterns. The compensations example is based on restatedev/restate-holiday.
This fixes #52.