Add correct transformers to gradle build configurations #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without the
ServiceFileTransformer, SPI files won't be merged. See apache/logging-log4j2#2099Because the
GrpcContextDataProvideris not needed in the lambda case (everything is on the same thread anyway, soLoggingContextSetterin the state machine is enough), we could also solve this issue differently, by having a separate module in the SDK that imports theGrpcContextDataProvideronly for the sdk-http-vertx case... Although perhaps let's see what they propose in the log4j2 issue and let's take action based on that... WDYT?