-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sdk-java templates #42
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor non-blocking comments, LGTM! 🚢
Should we add license headers to the handler source files?
jvm/java-blocking-lambda/src/main/java/dev/restate/sdk/examples/LambdaHandler.java
Outdated
Show resolved
Hide resolved
companion object { | ||
private val COUNT = StateKey.of("count", CoreSerdes.INT) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I was going to comment that a companion object is a more Kotlin-idiomatic way of declaring constants :-)
Update READMEs Add tests
2e7aa90
to
df2b0d2
Compare
For the headers we have another open issue #10. Can tackle it there. |
TODO: update module names and packages |
Fix restatedev/sdk-java#22